Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DeviantArt ripper not ripping descriptions #783

Closed
Wiiplay123 opened this issue Jul 6, 2018 · 5 comments
Closed

DeviantArt ripper not ripping descriptions #783

Wiiplay123 opened this issue Jul 6, 2018 · 5 comments

Comments

@Wiiplay123
Copy link
Contributor

  • Ripme version: 1.7.57 (Happened on 1.7.56 too but I didn't have time to write a bug report then)
  • Java version: Java(TM) SE Runtime Environment (build 1.8.0_51-b16)
  • Operating system: Microsoft Windows [Version 6.1.7601]

Expected Behavior

Rip descriptions when "Save descriptions" box is checkmarked.

Actual Behavior

Exactly the same thing as having the "Save descriptions" option disabled. No descriptions are saved, only the images are downloaded.

@Wiiplay123
Copy link
Contributor Author

Just checked the source code because I was going to try to cram the modern source code into my outdated personal ripme version and realised three things:

  1. The description code for deviantart was COMPLETELY taken out when it was updated for some reason
  2. It would be REALLY hard to put the new code into the old code
  3. New RipMe throws enough invalid session cookies to lock my IP out of my deviantArt account for 3-4 days, but that might be because of the initial cookies I gave it. :\

@cyian-1756
Copy link
Collaborator

The description code for deviantart was COMPLETELY taken out when it was updated for some reason

It's because the ripper moves from AbstractHTMLRipper (Which can save descriptions) to AbstractJSONRipper (Which currently can't save descriptions)

New RipMe throws enough invalid session cookies to lock my IP out of my deviantArt account for 3-4 days, but that might be because of the initial cookies I gave it. :\

That ought not happen. Are you getting any error messages?

@Wiiplay123
Copy link
Contributor Author

No error messages, it just keeps going without being logged in and I get locked out with it saying "Wrong password" and I have to wait 3-4 days without even trying to log in for it to work again :(

@Wiiplay123
Copy link
Contributor Author

DeviantArt's about to get a site upgrade, now I'll probably have to modify my personal build of RipMe based on 1.5.2 to be able to rip things again :\

@metaprime
Copy link
Contributor

[Mega-Thread] DeviantArt ripper is broken; yes we know -- de-duping all other DeviantArt issues to this one. #2063

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants