Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Incorrect DRAGON_SOUL_GIVEN events in match details/timeline JSON files since patch 15.1 #1026

Open
arbolitoloco1 opened this issue Jan 12, 2025 · 3 comments

Comments

@arbolitoloco1
Copy link

arbolitoloco1 commented Jan 12, 2025

Bug Description
Match details JSON files since patch 15.1 have a DRAGON_SOUL_GIVEN event which doesn't actually correspond to a team receiving drake soul in the real game, but to the moment the type of soul is decided (so when the second drake is killed). These incorrect events always have teamId: 0 which I think is invalid as well. For example on LOLTMNT99_343945 there is (frame 14, event 15):

{
  "name": "Cloud",
  "teamId": 0,
  "timestamp": 804191,
  "type": "DRAGON_SOUL_GIVEN"
}

Another example games are EUW1_7263613100 or LOLTMNT06_95160 (in this game there are two DRAGON_SOUL_GIVEN events, as one of the teams actually got the drake soul), but the bug is present in every game I could check, both in live server and esports.

@geozukunft
Copy link

So basically this just means that when the DRAGON_SOUL_GIVEN event is in the timeline with teamId 0 that is the informmation about what soul will be available in the game and when there is a teamId it means it has been claimed? I wouldn't neccesarrily seen that as an issue?

@DarkIntaqt
Copy link

DarkIntaqt commented Jan 12, 2025

I feel like the naming is a bit misleading but apart from that it makes sense to show which dragon soul will spawn - even tho not defeated yet

@arbolitoloco1
Copy link
Author

arbolitoloco1 commented Jan 12, 2025

Up to patch 15.1 DRAGON_SOUL_GIVEN was always used for a team receiving a drake soul iirc. In my case the code expects this type of event to represent that specific situation and then attributes the drake soul to either blue or red team (we use this data to make scoreboards for Leaguepedia), so with the new patch it stopped working.

It's true that it is really easy to workaround by just skipping the case where teamId is 0, but is also super confusing because the event name doesn't match what actually happened in the game and teamId being 0 doesn't make sense either.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants