Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🍛 Curry the API (more) #131

Open
favonia opened this issue Jun 18, 2024 · 2 comments · May be fixed by #140
Open

🍛 Curry the API (more) #131

favonia opened this issue Jun 18, 2024 · 2 comments · May be fixed by #140

Comments

@favonia
Copy link
Collaborator

favonia commented Jun 18, 2024

@jonsterling expressed that we should perhaps curry the API more aggressively. In particular, these four functions can be curried without causing confusion:

val include_singleton : Trie.path * (Param.data * Param.tag) -> unit
val include_subtree : Trie.path * (Param.data, Param.tag) Trie.t -> unit
val import_singleton : Trie.path * (Param.data * Param.tag) -> unit
val import_subtree : Trie.path * (Param.data, Param.tag) Trie.t -> unit
@favonia favonia added this to the 6.0.0 (big change) milestone Jun 18, 2024
@favonia favonia changed the title 🍛 Curry the API 🍛 Curry the API (more) Jun 18, 2024
@dannypsnl
Copy link

Do you mean

val _ : Trie.path -> (Param.data * Param.tag) -> unit

or

val _ : Trie.path -> Param.data -> Param.tag -> unit

I'm working on this.

@favonia
Copy link
Collaborator Author

favonia commented Jan 10, 2025

val _ : Trie.path -> (Param.data * Param.tag) -> unit

Currently this one, but maybe @jonsterling can chime in.

dannypsnl added a commit to dannypsnl/yuujinchou that referenced this issue Jan 10, 2025
resolve RedPRL#131

Signed-off-by: Lîm Tsú-thuàn <[email protected]>
@dannypsnl dannypsnl linked a pull request Jan 10, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants