Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Bwd.append to Bwd.append_list #31

Open
TOTBWF opened this issue Dec 18, 2024 · 2 comments
Open

Rename Bwd.append to Bwd.append_list #31

TOTBWF opened this issue Dec 18, 2024 · 2 comments

Comments

@TOTBWF
Copy link

TOTBWF commented Dec 18, 2024

Currently, Bwd.append has type 'a bwd -> 'a list -> 'a bwd; this isn't consistent with the API for lists, which has a homogenous List.append : 'a list -> 'a list -> 'a list. I propose that we rename the current Bwd.append to Bwd.append_list, Bwd.prepend to Bwd.prepend_list, and add a homogenous Bwd.append : 'a bwd -> 'a bwd -> 'a bwd function.

@favonia
Copy link
Contributor

favonia commented Dec 20, 2024

I think it's possible to justify the current usage of append, but I would like to talk about something else first: I'm a bit hesitant about prepand_list because it is not prepanding a list. Could you possibly elaborate on it?

@TOTBWF
Copy link
Author

TOTBWF commented Dec 29, 2024

I mostly chose the name for the sake of consistency; I suppose we could call it prepend_rev or prepend_bwd instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants