Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update serve-chrome to pull from new quay repo - now with latest tag #2089

Conversation

florkbr
Copy link
Contributor

@florkbr florkbr commented Oct 23, 2024

Tested locally in widget layout and seems to behave as expected:

➜  widget-layout git:(master) npm start

> [email protected] start
> HOT=true fec dev

? Which platform environment you want to use? stage
[fec] Warn:  The _unstableHotReload option in fec.config.js is deprecated. Use hotReload config instead.
[fec] Unsupported @patternfly packages version. Dynamic modules require version ^5.0.0. Got undefined.
  [fec] Debug:  ~~~Using variables~~~
  [fec] Debug:  Root folder: /Users/bflorkie/Development/github/RedHatInsights/widget-layout
  [fec] Debug:  Current branch: undefined
  [fec] Debug:  Using deployments: apps
  [fec] Debug:  Public path: /apps/widget-layout/
  [fec] Debug:  App entry: /Users/bflorkie/Development/github/RedHatInsights/widget-layout/src/entry.ts
  [fec] Debug:  Use proxy: true
[fec] Warn:  The _unstableHotReload option in shared webpack config is deprecated. Use hotReload config instead.
[fec] Warn:  The _unstableHotReload option in shared webpack plugins config is deprecated. Use hotReload config instead.
[fec] Info:  Starting chrome server...
Trying to pull quay.io/redhat-services-prod/hcc-platex-services-tenant/insights-chrome:latest...
Getting image source signatures
Copying blob sha256:999ae2c189a9795b209970f622923525a8bc360d7e9ada81c9cd132d69054158
Copying blob sha256:3c7f2cf6f926cc8738f7ff9aeeef9abc1518ec112d6f81b996c3b329ca820f58
Copying blob sha256:62aeb1273a26f143f16ea36a42f7fdcd899c036b8900eacc6afbedeb5d5145a7
Copying blob sha256:d3d3c25be73c16515094be2e536ccf77c51a6cba443d000edc68bc6d22f33f74
Copying blob sha256:1ae9ac8663f8ad3a5fce5ca4bb78141301eb5eb3a60fab057f81e0e30cdb7217
Copying blob sha256:133388727492505cb9d292d14f00942ad2915ab7df3ec1aabbea88cd25035f7b
Copying config sha256:d592bd9d2dce5ccf605e2f4cc61ffcfc8b8beca24b8f4bd3f1bc17a9279ba28a
Writing manifest to image destination
WARNING: image platform (linux/amd64) does not match the expected platform (linux/arm64)
d592bd9d2dce5ccf605e2f4cc61ffcfc8b8beca24b8f4bd3f1bc17a9279ba28a
fec-chrome-local
fec-chrome-local
[fec] Warn:  The _unstableHotReload option in fec.config.js is deprecated. Use hotReload config instead.
[fec] Unsupported @patternfly packages version. Dynamic modules require version ^5.0.0. Got undefined.
  [fec] Debug:  ~~~Using variables~~~
  [fec] Debug:  Root folder: /Users/bflorkie/Development/github/RedHatInsights/widget-layout
  [fec] Debug:  Current branch: undefined
  [fec] Debug:  Using deployments: apps
  [fec] Debug:  Public path: /apps/widget-layout/
  [fec] Debug:  App entry: /Users/bflorkie/Development/github/RedHatInsights/widget-layout/src/entry.ts
  [fec] Debug:  Use proxy: true
[fec] Warn:  The _unstableHotReload option in shared webpack config is deprecated. Use hotReload config instead.

... webpack: such build; very wow

webpack 5.95.0 compiled with 2 warnings in 3982 ms
No errors found.

FWIW using prod is broken, but it is because prod is using a 3 week old chrome-frontend commit ID that is not in our new quay repo:

➜  widget-layout git:(master) npm run start

> [email protected] start
> HOT=true fec dev

? Which platform environment you want to use? prod
[fec] Warn:  The _unstableHotReload option in fec.config.js is deprecated. Use hotReload config instead.
[fec] Unsupported @patternfly packages version. Dynamic modules require version ^5.0.0. Got undefined.
  [fec] Debug:  ~~~Using variables~~~
  [fec] Debug:  Root folder: /Users/bflorkie/Development/github/RedHatInsights/widget-layout
  [fec] Debug:  Current branch: undefined
  [fec] Debug:  Using deployments: apps
  [fec] Debug:  Public path: /apps/widget-layout/
  [fec] Debug:  App entry: /Users/bflorkie/Development/github/RedHatInsights/widget-layout/src/entry.ts
  [fec] Debug:  Use proxy: true
[fec] Warn:  The _unstableHotReload option in shared webpack config is deprecated. Use hotReload config instead.
[fec] Warn:  The _unstableHotReload option in shared webpack plugins config is deprecated. Use hotReload config instead.
[fec] Info:  Starting chrome server...
Trying to pull quay.io/redhat-services-prod/hcc-platex-services-tenant/insights-chrome:633b056...
Error: initializing source docker://quay.io/redhat-services-prod/hcc-platex-services-tenant/insights-chrome:633b056: reading manifest 633b056 in quay.io/redhat-services-prod/hcc-platex-services-tenant/insights-chrome: manifest unknown
[fec] Error:  Chrome server stopped!
[fec] Error:  Error: Command failed: podman pull quay.io/redhat-services-prod/hcc-platex-services-tenant/insights-chrome:633b056
    at checkExecSyncError (node:child_process:890:11)
    at execSync (node:child_process:962:15)
    at pullImage (/Users/bflorkie/Development/github/RedHatInsights/widget-layout/node_modules/@redhat-cloud-services/frontend-components-config/bin/serve-chrome.js:121:34)
    at /Users/bflorkie/Development/github/RedHatInsights/widget-layout/node_modules/@redhat-cloud-services/frontend-components-config/bin/serve-chrome.js:190:21
    at step (/Users/bflorkie/Development/github/RedHatInsights/widget-layout/node_modules/@redhat-cloud-services/frontend-components-config/bin/serve-chrome.js:33:23)
    at Object.next (/Users/bflorkie/Development/github/RedHatInsights/widget-layout/node_modules/@redhat-cloud-services/frontend-components-config/bin/serve-chrome.js:14:53)
    at fulfilled (/Users/bflorkie/Development/github/RedHatInsights/widget-layout/node_modules/@redhat-cloud-services/frontend-components-config/bin/serve-chrome.js:5:58)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5) {
  status: 125,
  signal: null,
  output: [ null, null, null ],
  pid: 47568,
  stdout: null,
  stderr: null
}

@florkbr
Copy link
Contributor Author

florkbr commented Oct 23, 2024

I have created PRs in app-interface to first bump ephem & stage to the konflux images, and another PR to bump prod. This should not be merged until the prod PR in app interface is merged - otherwise we will run into the image pull issue when targeting prod locally (see PR description).

@florkbr
Copy link
Contributor Author

florkbr commented Oct 24, 2024

I verified after prod was updated to use the new Konflux image things are working as expected:

widget-layout git:(master) npm start                                                 

> [email protected] start
> HOT=true fec dev

? Which platform environment you want to use? prod
[fec] Warn:  The _unstableHotReload option in fec.config.js is deprecated. Use hotReload config instead.
[fec] Unsupported @patternfly packages version. Dynamic modules require version ^5.0.0. Got undefined.
  [fec] Debug:  ~~~Using variables~~~
  [fec] Debug:  Root folder: /Users/bflorkie/Development/github/RedHatInsights/widget-layout
  [fec] Debug:  Current branch: undefined
  [fec] Debug:  Using deployments: apps
  [fec] Debug:  Public path: /apps/widget-layout/
  [fec] Debug:  App entry: /Users/bflorkie/Development/github/RedHatInsights/widget-layout/src/entry.ts
  [fec] Debug:  Use proxy: true
[fec] Warn:  The _unstableHotReload option in shared webpack config is deprecated. Use hotReload config instead.
[fec] Warn:  The _unstableHotReload option in shared webpack plugins config is deprecated. Use hotReload config instead.
[fec] Info:  Starting chrome server...
Trying to pull quay.io/redhat-services-prod/hcc-platex-services-tenant/insights-chrome:5a24dd1...
Getting image source signatures
Copying blob sha256:62aeb1273a26f143f16ea36a42f7fdcd899c036b8900eacc6afbedeb5d5145a7
Copying blob sha256:d3d3c25be73c16515094be2e536ccf77c51a6cba443d000edc68bc6d22f33f74
Copying blob sha256:1ae9ac8663f8ad3a5fce5ca4bb78141301eb5eb3a60fab057f81e0e30cdb7217
Copying blob sha256:3c7f2cf6f926cc8738f7ff9aeeef9abc1518ec112d6f81b996c3b329ca820f58
Copying blob sha256:999ae2c189a9795b209970f622923525a8bc360d7e9ada81c9cd132d69054158
Copying blob sha256:133388727492505cb9d292d14f00942ad2915ab7df3ec1aabbea88cd25035f7b
Copying config sha256:d592bd9d2dce5ccf605e2f4cc61ffcfc8b8beca24b8f4bd3f1bc17a9279ba28a
Writing manifest to image destination
WARNING: image platform (linux/amd64) does not match the expected platform (linux/arm64)
d592bd9d2dce5ccf605e2f4cc61ffcfc8b8beca24b8f4bd3f1bc17a9279ba28a
fec-chrome-local

...webpack doing its thing

webpack 5.95.0 compiled with 2 warnings in 605 ms
Type-checking in progress...
No errors found.

@florkbr florkbr merged commit 0b3e0f7 into RedHatInsights:master Oct 24, 2024
1 check passed
@florkbr florkbr added the release Once merged it will trigger bugfix release label Oct 24, 2024
@nacho-bot
Copy link
Collaborator

                      :soon::shipit::octocat:
     :bug:Shipit Squirrel has this release bugfix surrounded, be ready for a new version:beetle:

@nacho-bot
Copy link
Collaborator

     🌱 🌸 🌷 🌻 🌟 New version of package has been released 🌟 🌻 🌷 🌸 🌱

                The release is available on:

        :package:@redhat-cloud-services/frontend-components-config/v/6.3.2📦

             :boom:This feature is brought to you by probot🚀

@nacho-bot nacho-bot added the released Pr has been released label Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release Once merged it will trigger bugfix release released Pr has been released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants