Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

### Actions.tsx #1830

Closed
nicolethoen opened this issue Aug 10, 2023 · 3 comments
Closed

### Actions.tsx #1830

nicolethoen opened this issue Aug 10, 2023 · 3 comments
Assignees

Comments

@nicolethoen
Copy link
Contributor

file: https://github.com/RedHatInsights/frontend-components/tree/master/packages/components/src/PrimaryToolbar/Actions.tsx

Ensure PF4@5 compatibility

@kmcfaul
Copy link
Contributor

kmcfaul commented Aug 10, 2023

🦖

@kmcfaul
Copy link
Contributor

kmcfaul commented Aug 10, 2023

Minor spacing difference with menu position and overflow actions divider (divider isn't the last item so gets a bottom margin, while master has that margin at 0). Not entirely sure where the difference is coming from for the menu position.

master:
image

pf4@5:
image

@Hyperkid123
Copy link
Contributor

I'd say these changes are nothing we should block the release one. Can be addressed separately later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants