Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

### PageHeader.tsx #1797

Closed
nicolethoen opened this issue Aug 10, 2023 · 3 comments
Closed

### PageHeader.tsx #1797

nicolethoen opened this issue Aug 10, 2023 · 3 comments
Assignees
@thatblindgeye

Comments

@nicolethoen
Copy link
Contributor

file: https://github.com/RedHatInsights/frontend-components/tree/master/packages/components/src/PageHeader/PageHeader.tsx

Ensure PF4@5 compatibility
@thatblindgeye
Copy link

I'll take this

@thatblindgeye
Copy link

No discrepancies noticed, though this isn't importing anything from PatternFly and instead applying hardcoded PF classes.

It doesn't look like the pf-v5-c-page-header being hardcoded is being used anywhere in the codebase currently (not sure if it'd be being used outside, though)

@Hyperkid123
Copy link
Contributor

pf-v5-c-page-header

I don't think we use the class anywhere. I'll mark this for a tech debt clean up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thatblindgeye thatblindgeye

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Hyperkid123 @nicolethoen @thatblindgeye