Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

communictation with pdb down #109

Closed
grandrea opened this issue Jul 11, 2024 · 11 comments
Closed

communictation with pdb down #109

grandrea opened this issue Jul 11, 2024 · 11 comments

Comments

@grandrea
Copy link

Hello,
I tried to upload pdb via code today and got this error
pdb

@colin-combe
Copy link

mmtf.rcsb.org seems to be down

let's give it a bit to see if it comes back...

@colin-combe
Copy link

colin-combe commented Jul 11, 2024

thanks for error report

@colin-combe
Copy link

ok... guess its not coming back https://www.rcsb.org/news/feature/663129f765d8a8cacaf76f9f

@colin-combe
Copy link

so i'm gonna have to fix this

@colin-combe
Copy link

colin-combe commented Jul 11, 2024

its an NGL problem nglviewer/ngl#1045

@grandrea - you remember this thing whereby i hacked NGL so that chainnames could be 2 characters instead of 1? (colin-combe/ngl@71873ed)

How important is that still? It did break some things in NGL, just not things we used much.

In other words, what if I just updated to most recent version of NGL (without the hack) to fix this? Do you think that would mess things up for people?

@colin-combe
Copy link

it should be that this is fixed in the latest version of NGL on npm (https://www.npmjs.com/package/ngl).

So i should be able to fix this in xiVIEW and tidy some stuff up by importing NGL straight from npm (which xiVIEW already uses for managing JS dependencies).

But then you lose that 2 char hack.

Awaiting your input.

@grandrea
Copy link
Author

bye bye 2 char hack.

@grandrea
Copy link
Author

(that work is done afaik)

@colin-combe
Copy link

colin-combe commented Jul 11, 2024

So i should be able to fix this in xiVIEW and tidy some stuff up by importing NGL straight from npm

good that we have tests, because they now fail (after updating to most recent NGL).

Will look into what the problems are...

@colin-combe
Copy link

Things working again now?

@grandrea
Copy link
Author

yes, all good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants