Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I think its a bad idea to make this library depends on a web request to check version #25

Open
TitanDevX opened this issue Jan 1, 2025 · 1 comment
Labels
enhancement New feature or request

Comments

@TitanDevX
Copy link

Is your feature request related to a problem?

Yes, when I upgraded to the new version of signgui, I noticed some lag when using signs, all until I realized this library is connecting to 'https://raw.githubusercontent.com/Rapha149/NMSVersions/main/nms-versions.json' to match versions.

What solution would you like?

Why not just put it in a file?
Or in a const HashMap (you can use ChatGPT to convert json to HashMap to save time).

Describe alternatives you've considered

Since I can guarantee the server's version, I will just clone this repo and remove the version checker.

Any additional comments?

I really think its a bad idea to relay on a website that could go down or take time to load.

Thanks for your time!

@TitanDevX TitanDevX added the enhancement New feature or request label Jan 1, 2025
@Rapha149
Copy link
Owner

Rapha149 commented Jan 1, 2025

I did that so that if there's no breaking change in a version which sometimes happens I don't have to update the library. But the library should only connect to the json file once, so you could just do SignGUI.builder() in your onEnable to make the connection when the server starts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants