Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S10-packages/precompilation.t should not overwrite existing files #853

Open
ugexe opened this issue May 19, 2024 · 0 comments
Open

S10-packages/precompilation.t should not overwrite existing files #853

ugexe opened this issue May 19, 2024 · 0 comments

Comments

@ugexe
Copy link
Contributor

ugexe commented May 19, 2024

There are multiple spots in S10-packages/precompilation.t that overwrite modules in packages/. For example:

my $trigger-file = $rt128156-lib-prefix.IO.add('RT128156/Two.rakumod');
$trigger-file.IO.spurt($trigger-file.slurp);

These test should instead copy the root distribution path being used, e.g. $rt128156-lib-prefix.IO.add('RT128156'), to some temporary location, and then include that library path. This way each time the test is run the files in roast will not be changed. In Rakudo a similar pattern can be seen in t/02-rakudo/reproducible-builds.t

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant