-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rethink general layout and organization. #64
Comments
It has to be, because this is the API expected by Rakudo. Calling The core dumping referred is related to a moar issue and drifting away from global variables will help us, both class being facade and class as it is now are innocent. Most of the cleanup work for this ticket was already done in #80 and for parallel troubles we have a separate ticket, so closing. |
Please don't close this. First, it's labelled *wishlist", implying a vague desire for a general rethinking which is, if course, open to comments. Second, it's quite obvious that interface must be kept, that's a given. |
IMHO, re-imagining the whole thing is too vague to be a working ticket. The title states "refactor to a package", but the ticket itself says nothing about why it should be this way. In fact, it should be a class, so the title asks for something likely undesirable. Partially, re-thinking was already done in the PR mentioned. Partially, as there are still issues like #82 that want a solution. However, such issues have a specific problem to solve, while this issue does not state what is the issue here. Is there anything I am missing? |
I just think there's too much legacy code here. I've changed the title to see if it better reflects what I think. Thanks for reopening. |
Respecting the external API it needs to service, we probably need to rethink the layout and internal API so that we avoid errors such as the one told in #63
The text was updated successfully, but these errors were encountered: