Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify a minimum version requirement #58

Open
JJ opened this issue Jan 4, 2019 · 9 comments
Open

Specify a minimum version requirement #58

JJ opened this issue Jan 4, 2019 · 9 comments

Comments

@JJ
Copy link

JJ commented Jan 4, 2019

Check out Raku/examples#53 for an explanation. Use either 6.d or 2018.11, whatever is the most suitable. Add also version checks in the Travis conf.

@JJ JJ added the enhancement label Nov 3, 2019
paultcochrane added a commit to paultcochrane/Pod-To-HTML that referenced this issue Jul 30, 2020
This requirement should help avoid old language versions trying to run
code written in a more recent language version and thus also avoid
unnecessary build errors on e.g. Travis etc.

See Raku#58 as well as Raku/examples#53 for more
details.
paultcochrane added a commit to paultcochrane/Pod-To-HTML that referenced this issue Jul 30, 2020
This requirement should help avoid old language versions trying to run
code written in a more recent language version and thus also avoid
unnecessary build errors on e.g. Travis etc.

See Raku#58 as well as Raku/examples#53 for more
details.
@paultcochrane
Copy link

After looking at the Travis conf, it doesn't seem to be relevant to do any version checks there since everything comes from the docker image. Or would you like the docker image to start and then the Travis config to check the available Raku version in there? Somehow that solution feels complicated. @JJ what do you think?

@JJ
Copy link
Author

JJ commented Jul 30, 2020

Actually, there are docker images for most versions. Additionally, there are GitHub actions for different OSs. So maybe Gh actions is the way to go. Check what I just did for Pod-to-cached should you need an example

@paultcochrane
Copy link

Do you mean this commit: perl6/Pod-To-Cached@58a2752 ?

@paultcochrane
Copy link

Actually, there are docker images for most versions. Additionally, there are GitHub actions for different OSs. So maybe Gh actions is the way to go. Check what I just did for Pod-to-cached should you need an example

Do you propose that the Travis config explicitly use e.g. the 6.d version? The current version uses raku-test which doesn't contain a version number in the name. Is there a list of docker images that one should use? I've found your docker images (https://hub.docker.com/u/jjmerelo) but they don't mention a particular version of Raku. Do you mean maybe the rakudo-star docker image(s)? If you want to have GH actions then I feel that that task should be in a new ticket. Sorry for all the questions, unfortunately I don't find it very clear from your comment what you would like done here.

@JJ
Copy link
Author

JJ commented Jul 31, 2020

Do you mean this commit: perl6/Pod-To-Cached@58a2752 ?

Correct, that's the one.

@JJ
Copy link
Author

JJ commented Jul 31, 2020

Actually, there are docker images for most versions. Additionally, there are GitHub actions for different OSs. So maybe Gh actions is the way to go. Check what I just did for Pod-to-cached should you need an example

Do you propose that the Travis config explicitly use e.g. the 6.d version? The current version uses raku-test which doesn't contain a version number in the name. Is there a list of docker images that one should use? I've found your docker images

raku-test always contains the latest released version. And you are right, that one does not have tags; alpine-raku does. I will see if there's a good way of creating derived containers with tags

@paultcochrane
Copy link

Would it make sense to extend the list of docker images available in Raku/docker? That way one could point to community-maintained images.

@JJ
Copy link
Author

JJ commented Jul 31, 2020

It might, but I'm not totally sure who's actually uploading them to Docker hub. Again, it would make sense to create a GitHub Action that uploaded them automatically to Github registry...

@JJ
Copy link
Author

JJ commented Jul 31, 2020

I'm checking if there's some automated way to create Docker images with tags out of tagged base images, and yep, there is. However, it involves scripting the build process. I haven't done it so far. Again, probably easier with GitHub Docker Registry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants