Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linux: Clicking [link] buttons locks up the client #96

Open
Iiridayn opened this issue Jan 9, 2025 · 7 comments
Open

Linux: Clicking [link] buttons locks up the client #96

Iiridayn opened this issue Jan 9, 2025 · 7 comments
Assignees
Labels
bug Something isn't working invalid This doesn't seem right

Comments

@Iiridayn
Copy link

Iiridayn commented Jan 9, 2025

Describe the bug
In the [Library] tab, there are interesting mods, but I would like to inspect source code before installing them to keep my computer and account safe. However, I do not know the URL, and when I click the provided [GitHub] to learn it, the client locks up and must be killed from another shell. Similarly, attempting to learn what the Raidcore Addon Policy is with the caution buttons freezes up the client in like manner.

To Reproduce

  1. Install GW2 via Lutris, then add d3d11.dll to the same folder
  2. Launch the game
  3. Click the Nexus icon
  4. Navigate to the library
  5. Click a [GitHub] or caution button

Expected behavior
Either hovering will display the link so I can laboriously retype it, or it'll get dumped to the log, or to stdout. The one thing I least expect is to get the link opened :). However xdg-open might be a good tool to use if aiming to open links on Linux. I'm fine w/a workaround - just need the same access to data.

Screenshots
N/A - lockups are boring.

Additional context
Arch Linux, lutris-GE-Proton7-14-x86_64, i3 window manager, wrote Iiridayn/gw2-linux-multibox-launcher - happy to help debug to improve Linux support.

@Iiridayn Iiridayn added the bug Something isn't working label Jan 9, 2025
@DeltaGW2
Copy link
Member

DeltaGW2 commented Jan 9, 2025

To help troubleshoot this, it would be interesting to know:

  1. Does the "Open Addons Folder" button work?
  2. Does /wiki work in-game?

@tlex
Copy link

tlex commented Jan 9, 2025

Just tested this as well (running on i3wm also). With wine-ge-8-26 both /wiki and the links in nexus work, with Proton Experimental and with ge-proton, they don't.

And yes, I've checked that I have the configuration documented in https://askubuntu.com/questions/516307/how-do-i-change-default-wine-browser-to-native-ubuntu-browser-instead-of-ie

Agree with @DeltaGW2 on this, if /wiki doesn't work, it's probably something to do with the wine profile.

@DeltaGW2 DeltaGW2 added the invalid This doesn't seem right label Jan 9, 2025
@DeltaGW2
Copy link
Member

DeltaGW2 commented Jan 9, 2025

Nexus call: ShellExecuteA(0, 0, URL, 0, 0, SW_SHOW);
Game call: ShellExecuteA(0, 0, URL, 0, 0, SW_SHOWDEFAULT);

The nShowCmd parameter should have no noticable effect.

@Iiridayn
Copy link
Author

Iiridayn commented Jan 9, 2025

To help troubleshoot this, it would be interesting to know:

  1. Does the "Open Addons Folder" button work?
  2. Does /wiki work in-game?

The Open Addons Folder button does work. I'll have to wait until I'm home to check if the /wiki command works; I've had too many bad experiences by things opening browsers and corrupting my Chrome profiles (3 times now I've lost hundreds of tabs from Chrome, most recently around two months ago) so I'm very careful about opening links from outside a web browser.

@DeltaGW2 DeltaGW2 added wontfix This will not be worked on and removed wontfix This will not be worked on labels Jan 10, 2025
@DeltaGW2
Copy link
Member

The only possibility is that passing 0 as the verb picks the wrong default action, in other words it's trying something else than to open the URL. This can only be the case, if the default action or registry order was modified.

I will explicitly set the verb to "open", which might solve the issue on your end and properly open the browser with the given URL.

The nShowCmd as the game uses it on the other hand could be more problematic, therefore I will keep it as is and let the OS handle it.

Anything else will be beyond Nexus' control, such as when the "open" verb is removed entirely.

@DeltaGW2 DeltaGW2 self-assigned this Jan 10, 2025
@DeltaGW2
Copy link
Member

Any confirmation yet, whether /wiki works in-game? @Iiridayn

@Iiridayn
Copy link
Author

Iiridayn commented Jan 15, 2025

Sorry, haven't had time for games of late. Checked it just now, and it doesn't open anything, but also doesn't freeze up when I type /wiki et.

Edit: looks like xdg-open is called but is dumping core for some reason. Running it from the command line is properly opening a URL however.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working invalid This doesn't seem right
Projects
None yet
Development

No branches or pull requests

3 participants