Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for changing activity type for diffent types of media #130

Closed
1 task done
piplup55 opened this issue Jul 28, 2024 · 19 comments · Fixed by #136
Closed
1 task done

Support for changing activity type for diffent types of media #130

piplup55 opened this issue Jul 28, 2024 · 19 comments · Fixed by #136
Labels
enhancement New feature or request

Comments

@piplup55
Copy link

Is there an existing issue for this?

  • I have searched the existing feature requests

Is your feature request related to a problem? Please describe

there not really a problem, just a suggestion since discord now exposes the WATCHING, LISTENING TO, Competing in
https://x.com/advaithj1/status/1816655583107510517

Describe the solution you'd like

having a config option for the type of activity you want to use maybe it could be per media type, per media type would be really helpful if you use jellyfin for music aswell as media
example global:

  "discord": {
    "buttons": [{ }],
    "activity": "WATCHING"
  }

example per media:

    "music": {
      "display": ["album", "year"],
      "separator": "-"
       "activity": "LISTENING"
    }

Describe alternatives you've considered

maybe it could be a mix of both so you have a global type that can be overwritten by something like music

Additional context

No response

@piplup55 piplup55 added the enhancement New feature or request label Jul 28, 2024
@Radiicall
Copy link
Owner

I'll check the discord api and then maybe send a feature request to the discord-rich-presence library im using

@Radiicall
Copy link
Owner

I tested this locally and sent a PR to the discord-rich-presence library, its cool that they finally added this! I've gotten so many issues about it

@Radiicall
Copy link
Owner

Also i probably wont implement changing it but i will make it "Watching Jellyfin" and "Listening to Jellyfin", for books i might keep it as playing but im not sure yet

@piplup55
Copy link
Author

Also i probably wont implement changing it

yeah that's fair, it was just an afterthought i had when i was going to make the FR, the way you want to do it actually does make more sense

@Radiicall
Copy link
Owner

After doing some testing i think this still needs to wait, timestamps dont seem to be working, if you know of any FOSS projects that have working timestamps when showing as "Listening to", "Competing in" or "Watching" then please send me a link so i can take a look

@Radiicall Radiicall pinned this issue Jul 29, 2024
@piplup55
Copy link
Author

looks like it's bugged timestamps get ignored when setting the type to listening or watching

@Radiicall
Copy link
Owner

Yeah, it shows up on at least earlier versions of mobile discord, my phone is on 212.11 for instance but on desktop it doesnt work at all, guess we just have to wait and see if this is intended or if it will be fixed

@Radiicall
Copy link
Owner

vionya/discord-rich-presence#40 here's the PR i submitted to upstream and it has some example images

@Radiicall
Copy link
Owner

Radiicall commented Jul 30, 2024

I made a test version of jellyfin-rpc with this feature here

@XDark187
Copy link

XDark187 commented Aug 1, 2024

I've been using Vencord for a while with this plugin that allows replacing the activity with watching/streaming/competing etc.

Timestamps seems to be an issue with discord as the author of the plugin stated:

"ActivityTypes other than Playing will only show timestamps on mobile. It's a Discord issue."

The plugin has a cool toggle where you can swap presence name and details so it shows as "watching {movie name}" instead of "watching jellyfin". having an option to toggle this would be cool too.

image

@Radiicall
Copy link
Owner

I dont think swapping those two is something you can do through normal means, let me know if another project is doing that without modifying the client though and ill take a look at it

@Radiicall
Copy link
Owner

my fork got merged into https://github.com/vionya/discord-rich-presence, now all we need is for discord to make timestamps work again

@Radiicall
Copy link
Owner

Timestamps are sorta working but just the wrong way thanks to a discord update.. I hope they fix it and doesnt make the new way of not being able to specify start or end time permanent

@piplup55
Copy link
Author

it seems like discord has fixed the time bar this was added at the same time but was bugged i wonder if this could be used for movies?
image
i tested it on the youtube music app and it seems to work, it's not as good as timestamps but it might be something you can use
image

@BobbyWibowo
Copy link

I wonder if #136 will just work with that out of the box by any chance, if assuming they don't actually require new field types

@piplup55
Copy link
Author

I wonder if #136 will just work with that out of the box by any chance, if assuming they don't actually require new field types

i already checked it doesn't

@Radiicall
Copy link
Owner

https://discord.com/developers/docs/topics/gateway-events#activity-object-activity-timestamps it looks like having the bar there can be done

@Radiicall
Copy link
Owner

image
👀

@Radiicall Radiicall linked a pull request Sep 28, 2024 that will close this issue
@BobbyWibowo
Copy link

BobbyWibowo commented Sep 28, 2024

ended up building from git (i.e., jellyfin-rpc-git on AUR, lmao), it looks wonderful, thanksies

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants