Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config typo in docs for friendlyName #26

Open
zam6ak opened this issue Dec 10, 2023 · 0 comments
Open

Config typo in docs for friendlyName #26

zam6ak opened this issue Dec 10, 2023 · 0 comments

Comments

@zam6ak
Copy link

zam6ak commented Dec 10, 2023

Hi

The README.md shows dataSources snippet showing configuration for platform/app/public/config/default.js
I noticed that In the snippet, key friendlyName is shows as top property of the object and according to OHIF examples (release and master branches) it should be "under" configuration.

TL;DR;
Should it be:
dataSources.[].configuration.friendlyName
and not
dataSources.[].friendlyName

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant