Added query language test for arbitrary q expressions #349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: SystemsPurge <[email protected]>
Signed-off-by: SystemsPurge <[email protected]>
Signed-off-by: SystemsPurge <[email protected]>
Signed-off-by: SystemsPurge <[email protected]>
…guage-for-ngsi-ld-entities
Signed-off-by: SystemsPurge <[email protected]>
djs0109
requested changes
Nov 19, 2024
|
@SystemsPurge, great implementation! The logic is super clear. I have some minor comments. Some of them might already be fixed by me. Could you have a check again? |
Signed-off-by: SystemsPurge <[email protected]>
djs0109
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It should be possible to just add a q expression to the self.qs array and test again. In my own setup, expressions starting with '?q=' did not work for some reason.