-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: ngsi v2 tutorials are deprecated (#255) #259
Conversation
Did you try the suggested change from #255 (comment) ? Maybe However, not sure if that would fix the |
I don't think that parsing is the problem anymore in exercise 5, but I can't get pass the error |
@WaltherTrgovac thanks for the effort! Your implementation looks good to me so far. I fix the bug you mention. The problem was, that a service group with |
tutorials/ngsi_v2/e1_virtual_weatherstation/e1_virtual_weatherstation_solution.py
Show resolved
Hide resolved
As of right now, exercise 5 and 6 are producing following error messages: |
Summary of this long merge request... Most changes are just formatting to keep the consistency throughout the whole tutorials. ChangesIn general, these are the changes:
For each exercise the changes are made:
What has not been fixedExercise 5 and exercise 6 still not work properly due to the About the
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@WaltherTrgovac one last request for this PR. Could revise e6 as I made here? cf1659c
I think you have reverted these changes somehow, but it should be easy to fix
It's done |
# Conflicts: # tutorials/ngsi_v2/e4_iot_thermal_zone_sensors/e4_iot_thermal_zone_sensors_solution.py
As already mentioned in the issue, the pydantic method
parse_file_as
is causing most problems. In the commit 'attempt' I have tried to fix it, but it still isn't working. If someone could check whether the implementation is correct, that would be nice. I will also just try to get all the tutorials to work for now with this pull request and then later reformat the rest...