Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add geojson validation #258

Merged
merged 20 commits into from
Mar 19, 2024
Merged

feat: add geojson validation #258

merged 20 commits into from
Mar 19, 2024

Conversation

tstorek
Copy link
Collaborator

@tstorek tstorek commented Mar 12, 2024

closes #226

tstorek added 13 commits March 5, 2024 17:09
@tstorek
chore: enabled inheritance for ContextEntities
424da3f 
For #225
@tstorek
chore: added check for attributes
260943d 
For #225
@tstorek
chore: added test attribute assignment
1fc3c23 
For #225
@tstorek
chore: added validator for attribute assignment
ef6b9c4 
For #225
@tstorek
chore: added customizable ContextAttributes
6ff93b1 
For #225
@tstorek
Merge branch 'master' into 225-Make-ContextEntity-more-Customizable
e7d6328
@tstorek
chore: added clean up to tests
821cf56 
For #225
@tstorek
chore: fixed test_base.py
e4c8d0c 
For #225
@tstorek
chore: fix broken-tests
989894d 
For #225
@tstorek
chore: fix broken-tests and put correct types
3316713 
For #225
@tstorek
chore: added example for inheritance
f78f1cb 
For #225
@tstorek
chore: added example for inheritance and more implementation comments
5cb1408 
For #225
@tstorek
chore: fixed wrong type in tests
681ffad 
For #225
@tstorek
Copy link
Collaborator Author

tstorek commented Mar 12, 2024

depends on #225

@tstorek tstorek requested a review from djs0109 March 12, 2024 14:27
@tstorek tstorek self-assigned this Mar 12, 2024
@tstorek tstorek added the feature request Request a potential feature label Mar 12, 2024
@tstorek
Copy link
Collaborator Author

tstorek commented Mar 12, 2024

@djs0109 I am done so far with this. This can be reviewed after #225

@tstorek tstorek changed the title 226 add geojson validation feat: add geojson validation Mar 12, 2024
@tstorek
Copy link
Collaborator Author

tstorek commented Mar 12, 2024

@djs0109 once, again. I cannot see where it fails. Actually, the pull does not change to much. My own tests work as expected

@tstorek tstorek mentioned this pull request Mar 18, 2024
Closed
@djs0109 djs0109 merged commit 8f4a9a5 into master Mar 19, 2024
1 check passed
@djs0109 djs0109 mentioned this pull request May 7, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djs0109 djs0109 djs0109 approved these changes

Assignees

@tstorek tstorek

Labels
feature request Request a potential feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add geojson validation
2 participants
@tstorek @djs0109