Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@bghimireamd [Informative] #1298

Open
junliume opened this issue May 17, 2024 · 1 comment
Open

@bghimireamd [Informative] #1298

junliume opened this issue May 17, 2024 · 1 comment
Assignees

Comments

@junliume
Copy link
Collaborator

          @bghimireamd [Informative]

Had to rename MIOpen's #define ENV to #define MIOPEN_ENV because it was having name collision with recent introduction of CK's macro with same name #define ENV

Thanks for fixing the problem.

We do not export macro as a part of our public API and therefore it is OK to define whatever we want.

If CK exports its own macro (ENV) in its public API, then it is CK who must take care about possible collisions with their users, for example by adding and unique prefix (like CK_ or COMPOSABLE_KERNELS_). Or, better, they should avoid exporting macros in their API.

I'll take care about this.

Originally posted by @atamazov in ROCm/MIOpen#2961 (comment)

@junliume
Copy link
Collaborator Author

Should be fixed via #1296

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants