-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: compress all output json files into a archive.zip
#27
Comments
I think this was resolved by #82 |
It was not. This issue tracks the actual creation of that .zip archive (if it doesn't exist, the button won't do anything). Acceptance criteria:
|
huh... currently on https://rmi-pacta.github.io/pacta-dashboard-svelte/ if I click the "Save Data" button it downloads an "archive.zip" which contains JSON files. |
Indeed, because the |
Disabled as part of #35 |
I was able to locally reproduce the error mentioned in #35 : workflow.pacta.dashboard-1 | Error in write_delim(x, file, delim = ",", na = na, append = append, col_names = col_names, :
workflow.pacta.dashboard-1 | is.data.frame(x) is not TRUE
workflow.pacta.dashboard-1 | Calls: <Anonymous> ... zip_outputs -> %>% -> <Anonymous> -> write_delim -> stopifnot
workflow.pacta.dashboard-1 | Execution halted
workflow.pacta.dashboard-1 exited with code 1 Investigating. |
The error occurs because the datasets These empty JSON files are then read into R as a My recommendation here would be to add a check prior to calling workflow.pacta.dashboard/R/prepare_pacta_dashboard_data.R Lines 149 to 157 in 0ab208c
|
re-enable zip output and csv conversion. Note: if a JSON file is does not read as a data.frame (empty array, `[]`), then this will not emit a corresponding csv file, but will add the empty JSON to the archive (for later diagnostic purposes). Closes: #27
In the dashboard, we wish to allow users to download the input datasets. This would facilitate that.
The text was updated successfully, but these errors were encountered: