Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove FactSet database code #72

Closed
cjyetman opened this issue Jan 15, 2024 · 1 comment · Fixed by #73
Closed

remove FactSet database code #72

cjyetman opened this issue Jan 15, 2024 · 1 comment · Fixed by #73

Comments

@cjyetman
Copy link
Member

If the FactSet database is dead for good (@AlexAxthelm?), we should remove all the code and parameters related to that and effectively set update_factset: FALSE all the time

update_factset: TRUE

This would likely lead to significant simplification of the process. We should probably also deprecate and remove the relevant functions in pacta.data.preparation.

@AlexAxthelm
Copy link
Collaborator

I think we can remove that key entirely, and replace it with something like

default:
  ...
  factset_data_path: /mnt/inputs/factset

2023Q4:
  ...
  factset_data_path: /mnt/factset-extracted/factset-pacta_timestamp-20231231T000000Z_pulled-20240103T112256Z

github-merge-queue bot pushed a commit that referenced this issue Jan 24, 2024
closes #72 

FactSet database is gone, so this simplifies things a bit.

---------

Co-authored-by: Alex Axthelm <[email protected]>
Co-authored-by: Alex Axthelm <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants