implement validation for financial_data and abcd_flags_equity when ready
#222
Comments
This was referenced Apr 18, 2024
cjyetman
added a commit
that referenced
this issue
Apr 18, 2024
closes #18 Most validation errors originally found (below) have been resolved. Validation of `financial_data` and `abcd_flags_equity` has been removed for now and will be added in the future. investigation issues: - #196 - #197 - #198 - #198 relevant fixes in pacta.data.validation: - RMI-PACTA/pacta.data.validation#65 - RMI-PACTA/pacta.data.validation#66 - RMI-PACTA/pacta.data.validation#67 - RMI-PACTA/pacta.data.validation#68 relevant fix in pacta.data.preparation - RMI-PACTA/pacta.data.preparation#18 validation of `financial_data` and `abcd_flags_equity` has been removed from this PR, and future intended implementation is tracked here - #222 - dependent on RMI-PACTA/pacta.data.validation#69
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently,
pacta.data.validation::validate_financial_data()andpacta.data.validation::validate_abcd_flags_equity()throw an error when used in the data.prep process, e.g. #85RMI-PACTA/pacta.data.validation#69 intends to change those functions to allow some technically invalid, but likely intentional ISINs with a warning. Once that is complete, we should be able to use them here, as was intended in #85
depends on allow technically invalid, but likely intentional ISINs with a warning pacta.data.validation#69pacta.data.validation#185AB#10860
The text was updated successfully, but these errors were encountered: