-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
consider copying .git
into Docker container to facilitate precise tracking of code used to generate outputs in manifest
#138
Comments
If we copy just the
So from my current copy of this repo, on
|
I've found a way to preserve dirty/clean using From repo root:
Then from the destination directory:
|
For this repo, it's probably not that big of a deal, and I don't have strong opinions one way or the next, other than a general "yes, having the git info accessible in the manifest is nice". But for bigger repos (with long histories), it would be good to try to not put everything in the docker image. |
Agreed, if copying in |
thanks! I like the idea of only copying in the |
@cjyetman out of curiousity, can you add |
I think by not including the
.git
directory in #129, the manifest has now lost the functionality of tracking precisely what version of the run script was used, and even if any uncommitted local changes had been made (e.g. to the config file or the script itself) when running in a Docker container.We now see something like this...
as opposed to what we used to see and/or what we can see if running the "desktop"/local-RStudio way, like this...
@AlexAxthelm or @jdhoffa do you have opinions to the pros-cons of including the
.git
directory when copying over to the Docker container? I'm in inclined to start copying it in again because I think this git status information is very useful for tracking how the data.prep outputs were generated (I don't think there is any other indication of, for instance, what version of run_pacta_data_preparation.R was used). Or any other ideas on how to capture that info in the Docker container?The text was updated successfully, but these errors were encountered: