Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add .dockerignore file #128

Closed
cjyetman opened this issue Feb 12, 2024 · 0 comments · Fixed by #129
Closed

add .dockerignore file #128

cjyetman opened this issue Feb 12, 2024 · 0 comments · Fixed by #129
Assignees
@AlexAxthelm
Labels
Docker

Comments

@cjyetman
Copy link
Member

cjyetman commented Feb 12, 2024 •
edited
Loading

For this one, since it's not actually an R package, probably not. but in general, the .Xignore files, such as .Rbuildignore and .dockerignore can have huge impacts on build processes. (I'm annoyed that they're dotfiles).

As a quick example, .dockerignore excludes files from the docker build context, which means that when you have a line like this (currently on main):

workflow.data.preparation/Dockerfile

Line 20 in ca2d53e

COPY . /

if you don't have a .dockerignore defined, everything in the build context gets pulled into the image, which means that if you happen to have a copy of the rawdata inputs and outputs in the same directory, those get added. As does the .git directory, meaning that ever time you commit, you're invalidating the cache (and these problems multiply each other).

Originally posted by @AlexAxthelm in #117 (comment)

https://docs.docker.com/build/building/context/#dockerignore-files
@cjyetman cjyetman mentioned this issue Feb 12, 2024
Merged
@AlexAxthelm AlexAxthelm self-assigned this Feb 12, 2024
cjyetman added a commit that referenced this issue Feb 13, 2024
@cjyetman
add .dockerignore file
fdf53bc 
closes #128 

based on https://github.com/RMI-PACTA/workflow.pacta/blob/main/.dockerignore
@cjyetman cjyetman mentioned this issue Feb 13, 2024
Merged
cjyetman added a commit that referenced this issue Feb 13, 2024
@cjyetman @AlexAxthelm
add .dockerignore file (#129)
73ad0d7 
closes #128 

based on
https://github.com/RMI-PACTA/workflow.pacta/blob/main/.dockerignore with
the following differences
- allowing markdown files because I think it is reasonably relevant to
have the license and README markdown files baked into the image along
with the associated code
- excluding the `docker-compose.yml` because that's not relevant inside
the image (and I wonder if in some cases it could be a security concern,
e.g. if one did not want local path specifications to be revealed inside
the image)

---------

Co-authored-by: Alex Axthelm <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AlexAxthelm AlexAxthelm

Labels
Docker
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add .dockerignore file RMI-PACTA/workflow.data.preparation
2 participants
@cjyetman @AlexAxthelm