Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

save pre-flight files to a temp directory #100

Closed
cjyetman opened this issue Feb 9, 2024 · 2 comments
Closed

save pre-flight files to a temp directory #100

cjyetman opened this issue Feb 9, 2024 · 2 comments
Labels

Comments

@cjyetman
Copy link
Member

cjyetman commented Feb 9, 2024

Currently, pre-flight files are saved to the inputs directory, before ultimately the properly formatted RDS versions of them are saved to the outputs directory. I think it might be safer to initially save the pre-flight files to a temp directory so that the inputs directory could potentially be read-only. @jdhoffa and @AlexAxthelm do you have any concerns with that?

@jdhoffa
Copy link
Member

jdhoffa commented Feb 9, 2024

I think the pre-flights were (if I'm not mistaken) most useful because it was nice to have a cache for the FactSet and Scenario data.

Since it seems like we are moving towards those datasets being pulled/ stored/ versioned separately anyway (https://github.com/RMI-PACTA/workflow.factset and https://github.com/RMI-PACTA/workflow.scenario.preparation)

Since pacta.scenario.preparation offers a stable and versioned view of the scenario input datasets (and since FactSet is long gone), i think you're safe to do this now.

@cjyetman
Copy link
Member Author

Given the discussion beginning here, I'm closing this in favor of a strategy to eventually (optionally) copy all input files (including any "pre-flight" files) to a specific directory for archival (notably not a temp directory, and notably not a/the (possibly read-only) input directory).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants