Skip to content
This repository has been archived by the owner on Oct 23, 2024. It is now read-only.

feat: read P4B ABCD directly from xlsx, not from csv #72

Open
jdhoffa opened this issue Feb 29, 2024 · 3 comments
Open

feat: read P4B ABCD directly from xlsx, not from csv #72

jdhoffa opened this issue Feb 29, 2024 · 3 comments
Labels
feature a feature request or enhancement

Comments

@jdhoffa
Copy link
Member

jdhoffa commented Feb 29, 2024

Currently workflow scripts read.csv.
It would be prudent to read the raw data in as we receive it.
@cjyetman
Copy link
Member

FYI, there's a function for that https://rmi-pacta.github.io/pacta.data.preparation/reference/import_ar_advanced_company_indicators.html

@jacobvjk jacobvjk added feature a feature request or enhancement and removed enhancement labels Mar 5, 2024
@jacobvjk
Copy link
Member

jacobvjk commented Apr 2, 2024

this should actually be "read P4B ABCD directly from xlsx, not from csv". and that implies that we do not read PAMS format here.
will be handled in refactor: RMI-PACTA/pacta.multi.loanbook#7

@jdhoffa jdhoffa changed the title feat: read PAMS directly from xlsx feat: read P4B ABCD directly from xlsx, not from csv Apr 2, 2024
@jdhoffa
Copy link
Member Author

jdhoffa commented Apr 3, 2024

Changed!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
feature a feature request or enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@cjyetman @jdhoffa @jacobvjk