Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisit checks #516

Closed
MonikaFu opened this issue May 23, 2023 · 6 comments
Closed

Revisit checks #516

MonikaFu opened this issue May 23, 2023 · 6 comments
Labels
upkeep maintenance, infrastructure, and similar

Comments

@MonikaFu
Copy link
Collaborator

Right now there seem to be a lot of checks on different OSes which might be an overkill

@MonikaFu MonikaFu added the upkeep maintenance, infrastructure, and similar label May 23, 2023
@jdhoffa
Copy link
Member

jdhoffa commented Jan 24, 2024

The checks used in r2dii.plot () are in line with what we checks we use for r2dii.analysis. Not saying that means we need to keep them, but it at least means their in-line with one another.

Note: there is a discussion going on in parallel around standardizing our checks across the PACTA tech team.
Discussion is happening in the context of this repo: https://github.com/RMI-PACTA/demo_actions/issues

I would recommend closing this issue in favour of an issue/ discussion in that repo :-)

@MonikaFu
Copy link
Collaborator Author

@jdhoffa which issue exactly that is? I'm happy to move it there if it covers what I wanted to discuss here. Basically many times I had checks breaking for no reason and my intuition is that partly it is due to the fact that there are so many. Not sure if it is necessary to have so many checks for each PR. Maybe only for some when we make a release?

@jdhoffa
Copy link
Member

jdhoffa commented Jan 24, 2024

Well it is not an issue, but the repository itself, where we plan to discuss what workflows to use for all repositories.

Eventually, we will try to base all of our repositories workflows off of this central place so that we don't have a bunch of different versions of the same thing

@jdhoffa
Copy link
Member

jdhoffa commented Jan 24, 2024

I just made a new issue covering it here: RMI-PACTA/actions#12

@jdhoffa
Copy link
Member

jdhoffa commented Jan 24, 2024

We will discuss it as well on February 1st I believe. I think @AlexAxthelm is going to send an invite.

@MonikaFu
Copy link
Collaborator Author

Closing this issue as the number and breadth of checks will be decided for all our repos when we solve this issue: RMI-PACTA/actions#12.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
upkeep maintenance, infrastructure, and similar
Projects
None yet
Development

No branches or pull requests

2 participants