From cef463a24d298a0fa126bb4f7836bdccb8fdca06 Mon Sep 17 00:00:00 2001 From: Jackson Hoffart Date: Thu, 25 Apr 2024 12:20:10 +0200 Subject: [PATCH] upkeep: bump r2dii version in `helper-skip_if_r2dii_data_outdated.R` (#476) --- tests/testthat/helper-skip_if_r2dii_data_outdated.R | 2 +- tests/testthat/test-match_name.R | 8 ++++++++ 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/tests/testthat/helper-skip_if_r2dii_data_outdated.R b/tests/testthat/helper-skip_if_r2dii_data_outdated.R index 52b2686f..e3a19353 100644 --- a/tests/testthat/helper-skip_if_r2dii_data_outdated.R +++ b/tests/testthat/helper-skip_if_r2dii_data_outdated.R @@ -1,6 +1,6 @@ skip_if_r2dii_data_outdated <- function() { skip_if( - packageVersion("r2dii.data") <= "0.4.1", + packageVersion("r2dii.data") <= "0.5.0", "We expect different output" ) } diff --git a/tests/testthat/test-match_name.R b/tests/testthat/test-match_name.R index 00045808..bd8e4721 100644 --- a/tests/testthat/test-match_name.R +++ b/tests/testthat/test-match_name.R @@ -132,6 +132,8 @@ test_that("w/ row 1 of loanbook and crucial cols yields expected", { }) test_that("w/ 1 row of full loanbook_demo yields expected names", { + skip_if_r2dii_data_outdated() + out <- suppressWarnings(match_name(slice(loanbook_demo, 1L), fake_abcd())) expect_equal(names(out), expect_names_match_name) }) @@ -141,6 +143,8 @@ test_that("takes unprepared loanbook and abcd datasets", { }) test_that("w/ loanbook that matches nothing, yields expected", { + skip_if_r2dii_data_outdated() + # Matches zero row ... lbk2 <- slice(loanbook_demo, 2) lbk2 <- mutate( @@ -162,6 +166,8 @@ test_that("w/ loanbook that matches nothing, yields expected", { }) test_that("w/ 2 lbk rows matching 2 abcd rows, yields expected names", { + skip_if_r2dii_data_outdated() + # Slice 5 once was problematic (#85) lbk45 <- slice(loanbook_demo, 4:5) expect_named( @@ -171,6 +177,8 @@ test_that("w/ 2 lbk rows matching 2 abcd rows, yields expected names", { }) test_that("w/ 1 lbk row matching ultimate, yields expected names", { + skip_if_r2dii_data_outdated() + lbk1 <- slice(loanbook_demo, 1) expect_named(