Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test/386 use rmi actions #388

Merged
merged 6 commits into from
Jun 11, 2024
Merged

Test/386 use rmi actions #388

merged 6 commits into from
Jun 11, 2024

Conversation

AlexAxthelm
Copy link
Contributor

Move Package testing workflow to use standard RMI-PACTA action (https://github.com/RMI-PACTA/actions/blob/main/.github/workflows/R.yml)

Also remove dev-testing workflow, since there are no RMI dependencies.

@AlexAxthelm AlexAxthelm requested review from cjyetman and jdhoffa June 10, 2024 11:28
@AlexAxthelm AlexAxthelm marked this pull request as ready for review June 10, 2024 12:46
@AlexAxthelm AlexAxthelm requested a review from jacobvjk as a code owner June 10, 2024 12:46
This was linked to issues Jun 10, 2024
@AlexAxthelm AlexAxthelm self-assigned this Jun 10, 2024
jdhoffa
jdhoffa previously approved these changes Jun 11, 2024
jacobvjk
jacobvjk previously approved these changes Jun 11, 2024
@AlexAxthelm AlexAxthelm dismissed stale reviews from jacobvjk and jdhoffa via 1ed0d58 June 11, 2024 09:55
@AlexAxthelm
Copy link
Contributor Author

AlexAxthelm commented Jun 11, 2024

@jdhoffa @jacobvjk I think that in the current setup, this PR will never get to passing, since the one required check (ubuntu-latest) is removed in this PR.

Can we change that so it's either no required checks, or the required checks points at the ubuntu-latest from RMI-PACTA/actions?

That would be a repo-level "Settings" change

Screenshot_2024-06-11_10 09 34

@jacobvjk
Copy link
Member

@jdhoffa @jacobvjk I think that in the current setup, this PR will never get to passing, since the one required check (ubuntu-latest) is removed in this PR.

Can we change that so it's either no required checks, or the required checks points at the ubuntu-latest from RMI-PACTA/actions?

That would be a repo-level "Settings" change

Screenshot_2024-06-11_10 09 34

removed the required check, should work now

@jacobvjk jacobvjk self-requested a review June 11, 2024 11:35
@AlexAxthelm AlexAxthelm merged commit e49b263 into main Jun 11, 2024
16 checks passed
@AlexAxthelm AlexAxthelm deleted the test/386-use-rmi-actions branch June 11, 2024 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove "devel" R CMD CHECK workflow Use RMI-PACTA R actions
3 participants