Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

breaking change: simplify loan_size_* to only one version per loan book #373

Closed
jacobvjk opened this issue Apr 17, 2024 · 1 comment
Closed
Labels
breaking change ☠️ API change likely to affect existing code feature a feature request or enhancement large Likely will take over a week to finish

Comments

@jacobvjk
Copy link
Member

relates to #257

Instead of requiring separate columns for loan_size_outstanding, loan_size_outstanding_currency, loan_size_credit_limit, and loan_size_credit_limit_currency, we could simplify to keeping only two columns: loan_size and loan_size_currency.

While the distinction between the existing ones is useful in the analysis and indeed both outstanding and credit limit variables are used in actual applications, the simplification would be helpful for the following reasons:

  • the calculations in PACTA are the same regardless of how exactly the financial exposure is defined. simplifying to one version would lower maintenance burden and case-handling in downstream applications (e.g. P4S)
  • we cannot control exactly which variable a user has in their loan books and if that maps to our categories
  • our categories are actually not defined extremely precisely
  • the user would still be able to run PACTA both on outstanding loans and their credit lines. they would simply need to switch out the values in the loan book

OPEN: we could even think about a mechanism that allows the user to point to the relevant column in their loan book, rather than having them replace the values in loan_size. Open for discussion.

@jacobvjk jacobvjk added feature a feature request or enhancement breaking change ☠️ API change likely to affect existing code labels Apr 17, 2024
@jacobvjk jacobvjk changed the title breaking change: simplify loan_size_* to only one version per loan book breaking change: simplify loan_size_* to only one version per loan book Apr 17, 2024
@jacobvjk jacobvjk added the large Likely will take over a week to finish label Apr 17, 2024
@jacobvjk
Copy link
Member Author

closing this because George did not approve of the idea

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change ☠️ API change likely to affect existing code feature a feature request or enhancement large Likely will take over a week to finish
Projects
None yet
Development

No branches or pull requests

1 participant