Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upkeep: avoid setting GlobalEnv variables in functions #28

Closed
jdhoffa opened this issue Mar 25, 2024 · 1 comment
Closed

upkeep: avoid setting GlobalEnv variables in functions #28

jdhoffa opened this issue Mar 25, 2024 · 1 comment

Comments

@jdhoffa
Copy link
Member

jdhoffa commented Mar 25, 2024

Probably better to do this explicitly for each path, rather than abstracting it into a function called for it's side effects?
Likely requires changes in https://github.com/RMI-PACTA/workflow.transition.monitor

.GlobalEnv$project_location_ext <- cfg$paths$project_location_ext
.GlobalEnv$data_location_ext <- cfg$paths$data_location_ext
.GlobalEnv$template_path <- cfg$paths$template_location
.GlobalEnv$user_results_path <- cfg$paths$user_data_location

@cjyetman
Copy link
Member

The intention is to completely deprecate this and similar functions once workflow.transition.monitor is laid to rest

workflow.pacta already works without these functions and captures all parameters in a single cfg global variable
https://github.com/RMI-PACTA/workflow.pacta/blob/77f6ee025d06265e7ab412f01497773f1d812701/pacta_01.R#L25-L32

gonna close this as a duplicate of #19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants