deal with moving plot_match_success_rate() into r2dii.plot TODO

[cjyetman]

• related to upkeep: Review and remove all TODO, FIXME, and any other comments used to kick cans down roads #213

pacta.multi.loanbook/R/plots.R

Lines 1 to 2 in 03d3c10

	# TODO: move to `r2dii.plot` and export
	plot_match_success_rate <- function(data,

@MonikaFu is there still any realistic plan to move plot_match_success_rate() into r2dii.plot?

[jdhoffa]

Either way, suggested actions here:

• Open an issue in r2dii.plot with the suggestion
• Remove the TODO from pacta.multi.loanbook@main
• Close this issue

[cjyetman]

now tracked in RMI-PACTA/r2dii.plot#574

[MonikaFu]

@cjyetman I have no visibility on this. Depending on how useful that would be we could do this. Decision up to @jdhoffa and @jacobvjk I would say.

[cjyetman]

@cjyetman I have no visibility on this. Depending on how useful that would be we could do this. Decision up to @jdhoffa and @jacobvjk I would say.

@MonikaFu I have already removed the TODO comment from the code in this repo, and this issue will be closed when that PR merges.

The idea of moving plot_match_success_rate() into r2dii.plot has already been moved to RMI-PACTA/r2dii.plot#574, so it is now completely in your hands as the maintainer of that repo 😁

[jdhoffa]

@cjyetman I have no visibility on this. Depending on how useful that would be we could do this. Decision up to @jdhoffa and @jacobvjk I would say.

My recommendation is to leave RMI-PACTA/r2dii.plot#574 open without action. That way the idea is tracked (in a better format than a TODO), but we don't need to action anything yet (which I see no reason to do in the short term)

[cjyetman]

@cjyetman I have no visibility on this. Depending on how useful that would be we could do this. Decision up to @jdhoffa and @jacobvjk I would say.

My recommendation is to leave RMI-PACTA/r2dii.plot#574 open without action. That way the idea is tracked (in a better format than a TODO), but we don't need to action anything yet (which I see no reason to do in the short term)

RMI-PACTA/r2dii.plot#574 appears to have been a duplicate of RMI-PACTA/r2dii.plot#563 🤣 so I closed it (with appropriate comment and link) and left the original open

so just to be clear, this concept has now been moved to RMI-PACTA/r2dii.plot#563

[jacobvjk]

I think there is an argument for making the match success rate available in r2dii.plot so that it can be used in individual analyses in low threshold way. I am thinking IFC applications for example. It would also be good to have something like that available if/when we set up a P4B cookbook. But definitely no urgency right now

[cjyetman]

I think there is an argument for making the match success rate available in r2dii.plot so that it can be used in individual analyses in low threshold way. I am thinking IFC applications for example. It would also be good to have something like that available if/when we set up a P4B cookbook. But definitely no urgency right now

@jacobvjk maybe add that here RMI-PACTA/r2dii.plot#563