Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sweep pacta.data.preparation/tests/testthat/helper-fake_data.R for data faking functions #34

Open
jdhoffa opened this issue Apr 6, 2023 · 1 comment

Comments

@jdhoffa
Copy link
Member

jdhoffa commented Apr 6, 2023

And replace those functions with consolidated and centralized faking functions.

nit: maybe add a fixme/comment about eventually being able to replace this with functions from pacta.data.validation? I'd rather see these faker functions consolidated into one location rather than duplicated many places (possibly with slight variation)

Originally posted by @cjyetman in https://github.com/RMI-PACTA/pacta.data.preparation/pull/286#discussion_r1159527963

https://github.com/RMI-PACTA/pacta.data.preparation/blob/main/tests/testthat/helper-fake_data.R

AB#10853

@jdhoffa
Copy link
Member Author

jdhoffa commented Apr 6, 2023

To some extent this is related to #32, however I see it as subtly different.

On the one hand, it is useful to have a representative dataset to use for regression testing (a dataset that contains all different permutations of expected input) that would be #32

On the other hand, it's useful to have a minimal (one-row) dataset, that can be used and iterated on quickly for the purposes of unit testing. That is this issue.

@cjyetman cjyetman added the next label Apr 29, 2024
@jdhoffa jdhoffa added the ADO label Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants