-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider deprecating support for R versions older than 4 #13
Comments
@jdhoffa Are we skipping the tests because of the code used in testing, or because of the code used in the app? |
Not sure in every case to be honest. In the most recent case (that I added), it was because of code used in testing. |
Transferring this issue to https://github.com/RMI-PACTA/demo_actions/issues |
One more thought here: When I was working in government, it was not uncommon for some of the software I used to be very outdated. If the P4B code supports the R 3.x releases, maybe we should keep it that way. 3.0.3 came out ~10 years ago (which is coincidentally how old the version of SQL Server I was using was before it got end-of-life'd on security updates, and we were forced to update). Point being: in a security controlled environment, new features aren't compelling reasons to upgrade (I would not be surprised if some of those environments are still running R 3.0.0). |
I feel like R v3.5 (April 2018) was a really significant release with the introduction of the ALTREP framework and the introduction of v3 serialization for native R objects (e.g. <3.5 cannot read the default versions of RDS/RDA files created by 3.5+)... so that feels like a good benchmark minimum. |
All valid points. And Banks are likely in a similar setup to governments with restricted setups that may only support older versions, so perhaps 3.5 is a good baseline. |
|
Version 4 has been available for around 4 years now. I'm not sure how long we want to offer support.
Probably dangerous, and user-facing but we should at least discuss it.
We already skip a lot of tests on anything older than 4, which may give us fall security into thinking that things "work"
The text was updated successfully, but these errors were encountered: