Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Option for toggling the lintr on and off #15

Open
amirmasoudabdol opened this issue Sep 25, 2018 · 12 comments
Open

[Feature Request] Option for toggling the lintr on and off #15

amirmasoudabdol opened this issue Sep 25, 2018 · 12 comments

Comments

@amirmasoudabdol
Copy link

I'm wondering if it's feasible to add an option to toggle lintr on and off. I understand that this is possible through setting specific options but it'd be nice to just have a toggle button, maybe even making accessible in the Command Pallate.

@amirmasoudabdol amirmasoudabdol changed the title [Feature Request] [Feature Request] Option for toggling the lintr on and off Sep 25, 2018
@randy3k
Copy link
Member

randy3k commented Sep 25, 2018

Check the setting diagnostics.

@randy3k randy3k closed this as completed Sep 25, 2018
@randy3k
Copy link
Member

randy3k commented Sep 25, 2018

Oh. Didn’t read your post carefully. However, I am afraid that it is not possible to make it togglable. A restart is always needed.

@amirmasoudabdol
Copy link
Author

I'd say that's fine. There are options on other packages, even on Sublime that states the necessary restart. It's already good if there is an option to toggle it on/off.

@randy3k randy3k reopened this Sep 25, 2018
@sckott
Copy link

sckott commented Oct 30, 2018

Seems the diagnostics only hides the bottom pane - but does not turn off/on the lint hints in the files. Is it possible to still have tab completion for functions/etc. but not linting advice?

@randy3k
Copy link
Member

randy3k commented Oct 30, 2018

It should stop the entire linting feature. Try restarting the sublime

@sckott
Copy link

sckott commented Oct 31, 2018

thanks, i think that works

@divenyijanos
Copy link

Check the setting diagnostics.

Could you please elaborate on this? I tried "diagnostics": false in my R-IDE.sublime-settings to turn off linting, but it does not seem to have an effect (not even after a restart).

@randy3k
Copy link
Member

randy3k commented Apr 8, 2019

Are u using the latest version of languageserver? There is a bug in the previous version preventing the settings to pass over to the server.

@divenyijanos
Copy link

oh, thanks, I used 0.2.6, installing the latest version solved the issue

@divenyijanos
Copy link

Setting "diagnostics": false only disables linting or some other features too?

@randy3k
Copy link
Member

randy3k commented Apr 8, 2019

It only disables linting.

@richardli
Copy link

Apologies replying to an old issue. But the above "diagnostics": false trick does not seem to be able to turn off lint for ST4. I'm using the latest build 4169 and latest version of languageserver. Many thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants