Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stable horizontal inventory slot alignment #1400

Closed
wants to merge 1 commit into from
Closed

Stable horizontal inventory slot alignment #1400

wants to merge 1 commit into from

Conversation

jckling
Copy link
Contributor

@jckling jckling commented Dec 14, 2023

Summary

Enable horizontal layout group in HandleInventoryContainerAdded and disable in HandleInventoryContainerRemoved.

PR checklist

  • The game builds properly without errors.
  • No unrelated changes are present.
  • No "trash" files are committed.
  • Relevant code is documented.
  • Update the related GitBook document, or create a new one if needed.

Pictures/Videos

inventory.mp4

Tests

Are there any other items that would affect the horizontal layout slot?

Related issues/PRs

Closes #1365Closes #1365Closes #1365

@cosmiccoincidence cosmiccoincidence linked an issue Dec 14, 2023 that may be closed by this pull request
Stable inventory slot alignment #1365
Open
@cosmiccoincidence cosmiccoincidence added UI/UX Tasks related to the User Interface/Experience Fix A fix for a bug. labels Dec 14, 2023
@stilnat
Copy link
Contributor

stilnat commented Dec 14, 2023

Nice ! I'll have to test the following :

  • resizing the display
  • removing a hand
  • addding a hand (might be tricky as there's issue with the add hand command I think)

@jckling
Copy link
Contributor Author

jckling commented Dec 14, 2023 •
edited
Loading

@stilnat

Removing hand makes slots shift, I didn't consider this, the second solution (#1365 (comment)) might be the appropriate one.

@jckling jckling closed this Dec 14, 2023
@stilnat
Copy link
Contributor

stilnat commented Dec 14, 2023

@jckling okay thanks for testing it out !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Fix A fix for a bug. UI/UX Tasks related to the User Interface/Experience
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Stable inventory slot alignment
3 participants
@jckling @stilnat @cosmiccoincidence