Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optionally change fitbit client-id and secret based on user-config #45

Open
nivemaham opened this issue Jun 21, 2019 · 3 comments
Open
Labels
enhancement New feature or request

Comments

@nivemaham
Copy link
Member

It would be great if the fitbit connector request could be configured based on user specific fitbit client configuration. This would allow us to have multiple fitbit clients at a time.

@nivemaham nivemaham added the enhancement New feature or request label Jun 21, 2019
@yatharthranjan
Copy link
Member

This will require updates to the rest-authorizer i assume ?

@nivemaham
Copy link
Member Author

Yes. When we choose the client to authorize a user, we can persist it together and share it with connector.
Then the connector can use a user-config to get token and client config for requesting. Let's wait for @blootsvoets 's opinion.

@blootsvoets
Copy link
Member

Yes, makes sense. So one table for API client credentials, and another table for users, that reference the ID of the client. We can use the fact that we already distinguish clients in the rest authoriser, we would just need a new dialog to create a new client. The rest connector would need to fetch credentials.

Example data structure:

clients:
  - id: 1
    name: RADAR Fitbit client
    type: Fitbit
    clientId: abc
    clientSecret: abc

users:
  - id: 1
    projectId: abc
    userId: abc
    clientId: 1
    ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants