Skip to content
This repository has been archived by the owner on Aug 16, 2019. It is now read-only.

Don't List Transitive Dependencies #133

Open
opticyclic opened this issue Mar 22, 2018 · 1 comment
Open

Don't List Transitive Dependencies #133

opticyclic opened this issue Mar 22, 2018 · 1 comment

Comments

@opticyclic
Copy link

Here and in loads of other sample you list dependencies in gradle that are already included as transitive dependencies of other dependencies
https://github.com/corda/cordapp-example/blob/release-V3/kotlin-source/build.gradle#L47-L54

// Corda integration dependencies
cordaCompile "$corda_release_group:corda-core:$corda_release_version"
cordaCompile "$corda_release_group:corda-finance:$corda_release_version"
cordaCompile "$corda_release_group:corda-jackson:$corda_release_version"
cordaCompile "$corda_release_group:corda-rpc:$corda_release_version"
cordaCompile "$corda_release_group:corda-webserver-impl:$corda_release_version"

Can be replaced with

// Corda integration dependencies
cordaCompile "$corda_release_group:corda-finance:$corda_release_version"
cordaCompile "$corda_release_group:corda-webserver-impl:$corda_release_version"
cordaCompile  "$corda_release_group:corda:$corda_release_version"
@joeldudley
Copy link
Contributor

@opticyclic Please open a PR :) See https://docs.corda.net/contributing.html

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants