Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds -nojoy and -nosteamcontroller to dedicated cmdline args #689

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Adds -nojoy and -nosteamcontroller to dedicated cmdline args #689

wants to merge 2 commits into from

Conversation

Zonespace27
Copy link

@Zonespace27 Zonespace27 commented Apr 7, 2024 •
edited
Loading

Closes #634

Adds -nojoy (joystick inputs) and -nosteamcontroller (steam controller inputs) to the dedicated server's default args. This is supposed to stop the loading of the XInput DLLs, but at the moment does not. This PR is drafted while I try to figure out if there's something more that I need to do.

image

Update

After talking with Gecko on discord here, it was determined that even having -nojoy -nosteamcontroller on a client doesn't stop xinput from loading. As such, it seems that xinput's loading happens regardless. This PR will still close #634 due to it not truly being an issue- one we can fix, anyway. I'm undrafting this PR and leaving it as-is because adding these args might have a minimal perf benefit.

@Zonespace27 Zonespace27 marked this pull request as ready for review April 10, 2024 05:05
@r3muxd
Copy link

r3muxd commented Apr 29, 2024 •
edited by GeckoEidechse
Loading

a.) "nosteamcontroller" does not exist as a string so ????????????
b.) "nojoy" does not stop xinput dll from being loaded, it just skips initializing joysticks as the name implies; the proper way to fix this is to hook and rebuild CInputSystem::Init or bytepatch

@Zonespace27
Copy link
Author

Zonespace27 commented Apr 29, 2024 •
edited
Loading

a.) "nosteamcontroller" does not exist as a string so ????????????

Was going off of Valve documentation, I didn't consider that the steam controller was released after TF|2 stopped being updated, will fix

b.) "nojoy" does not stop xinput dll from being loaded, it just skips initializing joysticks as the name implies; the proper way to fix this is to hook and rebuild CInputSystem::Init or bytepatch

Will look into

@GeckoEidechse
Copy link
Member

Marking as draft until @Zonespace27 finished looking into it. @Zonespace27 (or anyone else) feel free to undraft at any moment or when suggested changes have been implemented

@GeckoEidechse GeckoEidechse self-assigned this Aug 19, 2024
@GeckoEidechse GeckoEidechse marked this pull request as draft August 19, 2024 15:30
@GeckoEidechse GeckoEidechse removed their assignment Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
Northstar Roadmap
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

-nojoy in dedi
3 participants
@Zonespace27 @r3muxd @GeckoEidechse