Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spurious keystrokes while switching between windows #7599

Closed
DemiMarie opened this issue Jul 3, 2022 · 4 comments · May be fixed by QubesOS/qubes-gui-daemon#104
Closed

Spurious keystrokes while switching between windows #7599

DemiMarie opened this issue Jul 3, 2022 · 4 comments · May be fixed by QubesOS/qubes-gui-daemon#104
Assignees
@DemiMarie
Labels
C: gui-virtualization diagnosed Technical diagnosis has been performed (see issue comments). P: major Priority: major. Between "default" and "critical" in severity. pr submitted A pull request has been submitted for this issue. R: cannot reproduce Resolution: Attempts to replicate the problem have not been reliably successful enough to proceed.

Comments

@DemiMarie
Copy link

How to file a helpful issue

Qubes OS release

R4.1, but R4.0 is probably affected too.

Brief summary

When cycling between windows, qubes are sent keystroke events that they really should not be.

Steps to reproduce

See QubesOS/qubes-gui-daemon#98 (comment) and related discussion.

Expected behavior

No extraneous keystrokes.

Actual behavior

Extraneous keystrokes.
@DemiMarie DemiMarie added T: bug C: gui-virtualization P: major Priority: major. Between "default" and "critical" in severity. labels Jul 3, 2022
@DemiMarie DemiMarie added this to the Release 4.0 updates milestone Jul 3, 2022
@DemiMarie DemiMarie self-assigned this Jul 3, 2022
DemiMarie added a commit to DemiMarie/qubes-gui-daemon that referenced this issue Jul 3, 2022
@DemiMarie
Pass all focus events to clients
9ac2d26 
Ignoring some focus events can result in the client and server
disagreeing on which window is focused or which keys have been pressed.
The results are unpredictable and generally undesirable.

Therefore, pass all focus events to clients.  The mode is still
overridden with NotifyNormal to avoid leaking window manager
implementation details.

Fixes QubesOS/qubes-issues#7599.
@DemiMarie DemiMarie mentioned this issue Jul 3, 2022
Open
@andrewdavidwong andrewdavidwong added diagnosed Technical diagnosis has been performed (see issue comments). pr submitted A pull request has been submitted for this issue. labels Jul 4, 2022
DemiMarie added a commit to DemiMarie/qubes-gui-daemon that referenced this issue Jul 6, 2022
@DemiMarie
Pass all focus events to clients
96d4767 
Ignoring some focus events can result in the client and server
disagreeing on which window is focused or which keys have been pressed.
The results are unpredictable and generally undesirable.  Furthermore,
it turns out that clients do care about the mode.  Therefore, pass all
focus events to clients, without clobbering the mode value.

Fixes QubesOS/qubes-issues#7599.
DemiMarie added a commit to DemiMarie/qubes-gui-daemon that referenced this issue Aug 2, 2022
@DemiMarie
Pass all focus events to clients
f01a742 
Ignoring some focus events can result in the client and server
disagreeing on which window is focused or which keys have been pressed.
The results are unpredictable and generally undesirable.  Furthermore,
it turns out that clients do care about the mode.  Therefore, pass all
focus events to clients, without clobbering the mode value.

Fixes QubesOS/qubes-issues#7599.
@marmarek
Copy link
Member

Steps to reproduce

Please include exact steps to reproduce here in the issue description. By doing simple alt-tab, I don't see any extra keystroke events being sent, so there must be something more to it.

@DemiMarie
Copy link
Author

Steps to reproduce

Please include exact steps to reproduce here in the issue description. By doing simple alt-tab, I don't see any extra keystroke events being sent, so there must be something more to it.

I don’t remember the details, but I think the problem may have been missing focus events.

@marmarek
Copy link
Member

That's what linked discussion suggests, but there is no specific issue details. And without ways to reproduce the issue, I can't verify if that change really fixes it (and won't accept the change blindly hoping it does).

@DemiMarie
Copy link
Author

Per private discussion with @marmarek it looks like this may have been a bug in R4.0’s XFWM4 that is fixed in the R4.1 version. In any case, I am not able to reproduce this problem.

Closing as “cannot reproduce”. If anyone finds a way to reproduce this bug, please comment here and the issue will be reopened.

@DemiMarie DemiMarie closed this as not planned Won't fix, can't repro, duplicate, stale May 30, 2023
@DemiMarie DemiMarie added the R: cannot reproduce Resolution: Attempts to replicate the problem have not been reliably successful enough to proceed. label May 30, 2023
@andrewdavidwong andrewdavidwong removed this from the Release 4.1 updates milestone Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DemiMarie DemiMarie

Labels
C: gui-virtualization diagnosed Technical diagnosis has been performed (see issue comments). P: major Priority: major. Between "default" and "critical" in severity. pr submitted A pull request has been submitted for this issue. R: cannot reproduce Resolution: Attempts to replicate the problem have not been reliably successful enough to proceed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Pass all focus events to clients DemiMarie/qubes-gui-daemon
3 participants
@marmarek @DemiMarie @andrewdavidwong