Add chepiga comment #149
Merged
Add chepiga comment #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I revised the comments on Chepiga ansatz
Add some descriptions on Chepiga ansatz
lkdvos
reviewed
Jun 6, 2024
Co-authored-by: Lukas <[email protected]>
redistribution of sentences and g=10.0=> 1.0
deleted "output"
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #149 +/- ##
==========================================
- Coverage 84.94% 84.90% -0.05%
==========================================
Files 73 73
Lines 4744 4744
==========================================
- Hits 4030 4028 -2
- Misses 714 716 +2 ☔ View full report in Codecov by Sentry. |
|
Failing tests are unrelated, so I'll merge this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wrote some additional comments on Chepiga ansatz. This code, in principle, shall be used near the criticality. Thus, I propose to change g to 1.0 instead too if possible.