Skip to content
This repository has been archived by the owner on Dec 18, 2021. It is now read-only.

allow complex parameter for TE #58

Merged
merged 2 commits into from
Jul 19, 2019
Merged

allow complex parameter for TE #58

merged 2 commits into from
Jul 19, 2019

Conversation

Roger-luo
Copy link
Member

@Roger-luo Roger-luo commented Jul 19, 2019

fix #57

cc: @mbeach42

@Roger-luo Roger-luo requested a review from GiggleLiu July 19, 2019 01:42
@Roger-luo
Copy link
Member Author

One problem for this is if the TE is constructed with a real number then it is only able to take real numbers. And you get an InexactError, which I think is fine.

@codecov
Copy link

codecov bot commented Jul 19, 2019

Codecov Report

Merging #58 into master will decrease coverage by 8.32%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #58      +/-   ##
==========================================
- Coverage   80.45%   72.12%   -8.33%     
==========================================
  Files          34       34              
  Lines        1146     1148       +2     
==========================================
- Hits          922      828      -94     
- Misses        224      320      +96
Impacted Files Coverage Δ
src/primitive/time_evolution.jl 76% <100%> (ø) ⬆️
src/layout.jl 16.15% <0%> (-64%) ⬇️
src/primitive/primitive.jl 50% <0%> (-50%) ⬇️
src/composite/concentrator.jl 58.33% <0%> (-6.89%) ⬇️
src/composite/control.jl 68.42% <0%> (-6.58%) ⬇️
src/primitive/measure.jl 76.47% <0%> (-5.89%) ⬇️
src/primitive/rotation_gate.jl 84.61% <0%> (-3.39%) ⬇️
src/composite/repeated.jl 70.96% <0%> (-3.23%) ⬇️
src/abstract_block.jl 65.82% <0%> (-2.54%) ⬇️
src/composite/kron.jl 92.85% <0%> (-2.33%) ⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8652c6...f588c36. Read the comment docs.

@GiggleLiu GiggleLiu merged commit 6feb56b into master Jul 19, 2019
@Roger-luo Roger-luo deleted the roger/patch-7 branch July 19, 2019 17:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

setiparams! for complex array
2 participants