Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: Pandascomparator crashes when comparing NaNs in colum with dtype=string[python] #7

Closed
DominikZuercherQC opened this issue Oct 31, 2024 · 0 comments · Fixed by #8
Closed

Bug: Pandascomparator crashes when comparing NaNs in colum with dtype=string[python] #7

DominikZuercherQC opened this issue Oct 31, 2024 · 0 comments · Fixed by #8

Comments

@DominikZuercherQC
Copy link
Collaborator

Minimal example for reproducing:

from tabulardelta import PandasComparator
import pandas as pd

old = pd.DataFrame([["bla"], ["foo"]], columns=["a"], dtype="string[python]")
new = pd.DataFrame([["bla"], [pd.NA]], columns=["a"], dtype="string[python]")

PandasComparator().compare(old,new)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Saveguard against invalid comparison in pandas comparator Quantco/tabulardelta
1 participant
@DominikZuercherQC