MAINT: update to use remarks admonition once style is updated
#442
Assignees
Comments
|
@longye-tian would you have time today to review this issue and setup a PR that includes a remark admonition that we can use as a test case. I will coordinate updates to the theme but it would be helpful to see how they look in a real work case. |
longye-tian
added a commit
that referenced
this issue
Jul 1, 2024
Dear John, This pull request is for #442. I use the geom_series.md lecture as an example to test the current admonition style. Best, Longye
2 tasks
|
Started the process of updating executablebooks/sphinx-proof#99 Once that is accepted and merged we can then make progress on improvements to the style |
|
This PR is now open |
mmcky
added a commit
that referenced
this issue
Sep 25, 2024
…-theme (#493) * [geom_series] remark_admonition Dear John, This pull request is for #442. I use the geom_series.md lecture as an example to test the current admonition style. Best, Longye * TST: install main branch version of sphinx-proof * test with new css definition * test the new css styling for remark * test updated quantecon-book-theme * upgrade quantecon-book-theme==0.7.2 * update branch until released for sphinx-proof * enable sphinx-proof==0.2.0 * update software for collab testing * remark_money_inflation Add remark admonition for money_inflation.md * remark_unpleasent Add remark admonition to unpleasent.md * remark_money_inflation_nonlinear Add remark admonition for money_inflation_nonlinear.md --------- Co-authored-by: mmcky <[email protected]> Co-authored-by: Matt McKay <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
There are lectures such as #440 (comment)
that make use of
remarksthat could be nicely wrapped in admonitions, however the style is currently overly bold insphinx-proofand gives too much weight to the contents.Once executablebooks/sphinx-proof#98 is resolved we can loop through and add the admonitions to this lecture series.
The text was updated successfully, but these errors were encountered: