Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add groupby feature to documentation #96

Open
karishmadaga opened this issue May 24, 2021 · 4 comments
Open

add groupby feature to documentation #96

karishmadaga opened this issue May 24, 2021 · 4 comments
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers

Comments

@karishmadaga
Copy link
Collaborator

groupby missing in readthedocs features, getting started, and on github readme

@karishmadaga karishmadaga added the documentation Improvements or additions to documentation label May 24, 2021
@karishmadaga karishmadaga added the good first issue Good for newcomers label May 25, 2021
@haz
Copy link
Contributor

haz commented May 25, 2021

Is this largely because this method is a hidden one? Or do you mean primarily on the top-level features lists?

@karishmadaga
Copy link
Collaborator Author

are you linking to the _is_valid_groupby function? nah that doesn't need to be public, it's just for our purposes.

yes I meant for the features list (readthedocs, github readme) and adding an example in the getting started page of readthedocs

@karishmadaga
Copy link
Collaborator Author

ah, I just remembered, we should probably wait until the next release to update public documentation, right? we've been updating the docs for the past few commits, so we can tag new features as being available in the next release or hide them for now. what do u think?

@haz
Copy link
Contributor

haz commented Jul 14, 2021

Only 1.5 months late to respond :P. There are docs on the core.py, but did you mean another place for it to be listed?

As for deploying, that'll hopefully be solved with #103

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants