Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unable to Use Validation (valid) Feature While Starting Sequence Parallelism 无法使用验证（valid）功能 #2

Open
1 task done
wuyuhan3z opened this issue Jan 14, 2025 · 2 comments
Open
1 task done

Unable to Use Validation (valid) Feature While Starting Sequence Parallelism 无法使用验证（valid）功能 #2

wuyuhan3z opened this issue Jan 14, 2025 · 2 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@wuyuhan3z
Copy link

Reminder

  • I have read the README and searched the existing issues.

System Info

/

Reproduction

/

Expected behavior

Both sequence parallelism and the validation feature should work concurrently.

Others

No response
@HaoshengZou
Copy link
Collaborator

Thanks for pointing it out.
We haven't adapted prediction_step for SP so currently validation during training doesn't work with SP.
We'll adapt it later. In the meantime, feel free to implement and submit PR :P

@wuyuhan3z
Copy link
Author

wuyuhan3z commented Jan 14, 2025 via email

@HaoshengZou HaoshengZou added bug Something isn't working good first issue Good for newcomers labels Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@HaoshengZou @wuyuhan3z