Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't mix tabs and spaces indentation? #40

Closed
fingolfin opened this issue Jan 16, 2024 · 0 comments · Fixed by #41
Closed

Don't mix tabs and spaces indentation? #40

fingolfin opened this issue Jan 16, 2024 · 0 comments · Fixed by #41

Comments

@fingolfin
Copy link
Contributor

Your source code currently freely mixes tabs and spaces for indentation. That makes it hard to read the code unless one has the editor set to the exact correct tab width.

I would recommend to use either tabs or spaces for indentation, but never mix them.

BTW to avoid a misunderstanding, this like my other recent issues is independent from adding the package to the GAP distribution, i.e., I am not waiting for these issues to be resolved (only the test failure needs to be resolved), I am just adding them because I observer them just now while looking at your code again.

@LeonidPryadko LeonidPryadko linked a pull request Jan 20, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant