Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wishlist: HSQC simulation based on RDKit adjacency matrix #21

Open
mkedwards opened this issue Nov 8, 2024 · 1 comment
Open

Wishlist: HSQC simulation based on RDKit adjacency matrix #21

mkedwards opened this issue Nov 8, 2024 · 1 comment
Assignees
Labels
bug Something isn't working documentation Improvements or additions to documentation duplicate This issue or pull request already exists enhancement New feature or request question Further information is requested wontfix This will not be worked on

Comments

@mkedwards
Copy link

Is your feature request related to a problem? Please describe.
Not a problem, just a gap in the tools universe. When modeling both 13C and 1H chemical shifts using ORCA, I'd like to be able to simulate an HSQC plot similar to what NMRDB produces.

Describe the solution you'd like
A new "HSQC plot" tab in the "NMR Spectrum" panel that shows cross-peaks for C+H pairs that are bonded according to RDKit's idea of an adjacency matrix (relatively easily computed from an XYZ block?). Probably needs element-specific delta_ref in the "shift scaling" tab as well. Here's a reasonable thing to imitate, from NMRDB's interface.
image

Describe alternatives you've considered
None of the tools out there seem to be able to consume an ORCA output file (or anything I can generate from an ORCA output file with a reasonable degree of effort; generating JCAMP-DX seems like a lot of work) and render an HSQC plot.

Additional context
NMRDB's ability to highlight groups of chemically very similar atoms when you float the mouse pointer over an HSQC cross-peak is pretty cool, but that's out of scope; the plot is the important thing for preparing for a real NMR run.

image

@mkedwards mkedwards added bug Something isn't working documentation Improvements or additions to documentation duplicate This issue or pull request already exists enhancement New feature or request question Further information is requested wontfix This will not be worked on labels Nov 8, 2024
@ajs99778
Copy link
Contributor

ajs99778 commented Nov 8, 2024

This should be doable. I'd probably use the bonds that are shown in ChimeraX to determine adjacency, so you can edit them in ChimeraX if you wanted to. I'll have to think about whether I want to add this to the existing NMR tool or make a new 2D NMR tool to accommodate the extra buttons for shift scaling, number of bonds, or whatever else.

The NMR tool currently just displays the indices of atoms when you double click a peak. I could probably make it selects the atoms on the structure as well. The double clicking functionality is pretty much copy-pasted from the IR or UV/vis plots, where selecting atoms didn't make sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation duplicate This issue or pull request already exists enhancement New feature or request question Further information is requested wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants