Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration to Typescript (Question) #34

Open
saran-surya opened this issue May 17, 2023 · 15 comments
Open

Migration to Typescript (Question) #34

saran-surya opened this issue May 17, 2023 · 15 comments

Comments

@saran-surya
Copy link

Hi @LeonOstrez ,
Is there any plan to migrate the project to Typescript by any chance. As it would for helpful for development and maintenance.

Just as a suggestion as it will be easier if done right on start of the project rather than, processing it in a much more complicated stage. Kindly let me know if you plan for a migration.

World be happy to help 🙌

@LeonOstrez
Copy link
Member

Hi @saran-surya thanks so much for the feedback.

We definitely have in plans to migrate to Typescript as soon as we will have resources for that. Currently we are preoccupied and that task is in backlog.

We are open to contributions so if you, or anyone else, is interested in contributing we would be extremely happy!

@saran-surya
Copy link
Author

I would be happy to help, Is it okay to branch the latest HEAD of the project for the migration ?

@LeonOstrez
Copy link
Member

This is amazing! Thank you so much.

I think best thing would be if you wait until next week. We will launch one bigger feature next week, so if you start after that it would help with not having many conflicts when merging.

If that is ok with you, I can ping you here next week when launch is live and then you can branch out for migration. How does that sound? But if you are eager to get started then yes, you can branch latest HEAD

@saran-surya
Copy link
Author

saran-surya commented May 18, 2023 via email

@LeonOstrez
Copy link
Member

Great! I'll keep you updated

@LeonOstrez
Copy link
Member

Hey @saran-surya sorry for a late reply. There was a lot of new changes coming so I wanted to wait for the merge. We had crazy few weeks behind us and we just launched new big feature in [email protected]. If you have time and still would like to contribute, we would be more than happy. Let me know if you need my help with anything.

Also, I would love to hear your thoughts on our new feature! Now you can create unit tests for your whole repository using only 1 command! Check out this video if you are interested to know more!

Looking forward to hearing from you!

@saran-surya
Copy link
Author

saran-surya commented Jun 8, 2023 via email

@krzysztofnowak
Copy link

I'll be happy to see Typescript support too

@saran-surya
Copy link
Author

Hey @saran-surya sorry for a late reply. There was a lot of new changes coming so I wanted to wait for the merge. We had crazy few weeks behind us and we just launched new big feature in [email protected]. If you have time and still would like to contribute, we would be more than happy. Let me know if you need my help with anything.

Also, I would love to hear your thoughts on our new feature! Now you can create unit tests for your whole repository using only 1 command! Check out this video if you are interested to know more!

Looking forward to hearing from you!

So are we looking at a complete rebuild to Typescript, or only make types available for the end package ?

Like both are possible, but the first one would require a knowledge session regarding the project dev flow.

@saran-surya
Copy link
Author

https://github.com/saran-surya/pythagora/tree/typescript-migration
This is the branch that will be worked on for the migration

@LeonOstrez
Copy link
Member

hey @saran-surya sorry, I somehow missed your last message!

How much would it take you to do complete rebuild to Typescript? We are adding new features very fast so my worry is that its gonna make it really hard for you...

If you do need any help feel free to ping me and if needed we can even hop on a quick call.

@saran-surya
Copy link
Author

saran-surya commented Jun 15, 2023 via email

@LeonOstrez
Copy link
Member

Sounds great to me! I'll send you email and we can schedule call there.

@khareyash05
Copy link

Hi @LeonOstrez Congratulations on being selected for YC W24 batch. Are we open to working on this issue? I would love to help.

@saran-surya
Copy link
Author

saran-surya commented Mar 1, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants