Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review docker-compose.md file #2

Open
upkarlidder opened this issue Jul 21, 2021 · 2 comments
Open

Review docker-compose.md file #2

upkarlidder opened this issue Jul 21, 2021 · 2 comments
Assignees
Labels
documentation Improvements or additions to documentation enhancement New feature or request

Comments

@upkarlidder
Copy link
Member

upkarlidder commented Jul 21, 2021

Please review and run through https://github.com/Pyrrha-Platform/Pyrrha-Deployment-Configurations/blob/WIP-ul-docker-compose/Docker_Compose.md.

You will have to checkout WIP-ul-docker-compose branch.

The only part left is the simulator. The rest should work. At the end of the exercise, you will get an empty dashboard with no devices.

You should see seven services running as explained in the readme.

@Aquijada52
Copy link
Member

General feedback:

  • emphasis on the root repo "Pyrrha" being case sensitive, accidentally did "Pyrrha" to begin with
  • in docker files to not remove "{}" from "${MDB_PASSWORD}", so may need to update that code block

When working with vcap.local.json file

  • directions on the md file seem slightly out of order with the file order
    • user vars : ( directions on session secret, pyrrha api key, jwt_secret)
    • ibm cloud: (api key)
    • services: (clientid, tenantid, etc)
  • user_vars:
    • name change from "openeew_api_key" to "pyrrha_api_key"

Deployment:

  • include git checkout -b WIP-ul-docker-compose && git pull origin WIP-ul-docker-compose but the user may not need this when changes are pushed to the main branch
  • docker-compose up output TBD
    • possibly have a gif of how it may look, as well as mentioning that it should keep running on an "infinite loop"

@mrodrise my feedback is complete, please let me know what you also think when you review and run through it so that I may create a pull request.

@krook krook added documentation Improvements or additions to documentation enhancement New feature or request labels Jul 27, 2021
@krook
Copy link
Member

krook commented Apr 5, 2022

Is this resolved @upkarlidder?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants